Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure TrivialGroup(IsPermGroup) has zero generators #1247

Merged
merged 1 commit into from
Apr 17, 2017

Conversation

fingolfin
Copy link
Member

This addresses #1239 (or at least parts of it).

@codecov
Copy link

codecov bot commented Apr 14, 2017

Codecov Report

Merging #1247 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1247      +/-   ##
==========================================
+ Coverage   60.61%   60.62%   +<.01%     
==========================================
  Files         929      929              
  Lines      286313   286327      +14     
  Branches    16855    16855              
==========================================
+ Hits       173561   173572      +11     
- Misses     108436   108437       +1     
- Partials     4316     4318       +2
Impacted Files Coverage Δ
grp/basicprm.gi 87.5% <100%> (-0.15%) ⬇️
hpcgap/src/vars.c 38.02% <0%> (-0.09%) ⬇️
src/read.c 79.71% <0%> (-0.03%) ⬇️
hpcgap/src/funcs.c 48.8% <0%> (ø) ⬆️
src/code.c 86.95% <0%> (+0.08%) ⬆️
src/gap.c 52.99% <0%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42cfe9f...2ae591f. Read the comment docs.

@fingolfin fingolfin merged commit 747069f into gap-system:master Apr 17, 2017
@fingolfin fingolfin deleted the mh/trivial-zero branch April 20, 2017 19:52
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.9.0 milestone Jan 20, 2018
@olexandr-konovalov olexandr-konovalov added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants