Check when we manually increment stack depth, we correctly decrement it on return

[ChrisJefferson]

This just adds some more tests for #1151, to check the incrementing and decrementing of stack depth works correctly by doing lots of calls in a loop.

[codecov]

Codecov Report

Merging #1160 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1160   +/-   ##
=======================================
  Coverage   68.36%   68.36%           
=======================================
  Files         435      435           
  Lines      230679   230679           
=======================================
  Hits       157706   157706           
  Misses      72973    72973

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70e9509...bc7557a. Read the comment docs.

[fingolfin]

This is not clear as to what "stack" is meant. I assume this refers to the RecursionDepth variable in the kernel -- I think the comment should say so explicitly.

Also, I think this implicitly relies on the RecursionTrapInterval being "small" enough (right now it is set to 5000). That's fine, but I think I'd mention this, too. E.g.:

# Check that the RecursionDepth counter in the kernel is incremented and
# decremented correctly. If it isn't decremented correctly, then it will
# eventually exceed the `RecursionTrapInterval` (which normally is
# 5000), and the test will fail due to an unexpected error message.

[ChrisJefferson]

done. Also reduced length of commit message, in case that was coming next.

[fingolfin]

Perhaps rebase to avoid test fluctuations?

[olexandr-konovalov]

Has this been rebased? Ready to merge? Suspicious that tests are added, but coverage remains the same.

[ChrisJefferson]

I wouldn't expect this to hit any more lines of code, it's just checking if we do something a lot nothing breaks, and coverage doesn't care about number of times a line is executed :)