Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak tests a bit #1100

Merged
merged 8 commits into from
Jan 25, 2017
Merged

Tweak tests a bit #1100

merged 8 commits into from
Jan 25, 2017

Conversation

fingolfin
Copy link
Member

While working on removing GAPstones (see PR #1072), I made some tweaks and improvements to various tests, mainly to speed them up. I figured we might want to merge this workindependently of the GAPstones removal. In particular, it should be uncontroversial, which the removal of GAPstones might not be.

@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: tests issues or PRs related to tests labels Jan 21, 2017
@fingolfin fingolfin mentioned this pull request Jan 21, 2017
@codecov-io
Copy link

codecov-io commented Jan 21, 2017

Current coverage is 54.32% (diff: 100%)

Merging #1100 into master will decrease coverage by 0.21%

@@             master      #1100   diff @@
==========================================
  Files           432        432          
  Lines        224765     224765          
  Methods        3431       3431          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits         122572     122095   -477   
- Misses       102193     102670   +477   
  Partials          0          0          

Powered by Codecov. Last update 75245e7...2abc05d

@fingolfin fingolfin mentioned this pull request Jan 22, 2017
@fingolfin
Copy link
Member Author

On #1072, @alex-konovalov mentioned that the new testextra dir could be hooked up to be run by tst/teststandard.g. Sure, that's easy to do.

As a matter of fact, I think we should rename the subdirs testinstall, teststandard to, say, testquick and testslow or so -- to emphasize that there is not a 1-to-1 correspondence between them, and the "testsuites". Already now, teststandard.g also runs the tests from testinstall. And testtravis runs a mishmash, too.

@markuspf
Copy link
Member

I shuld probably mention #790, which was a (failed) attempt to do what you propose.

@fingolfin
Copy link
Member Author

@markuspf Thanks for that pointer! Also https://github.com/gap-system/gap/wiki/Testing-methods-and-targets. I'll see what I can do.

@ChrisJefferson
Copy link
Contributor

This is all totally fine. Will merge later unless anyone raises issues.

There are obvious followups to come -- but this can be merged as is for now.

@markuspf markuspf merged commit 2abc05d into gap-system:master Jan 25, 2017
@fingolfin fingolfin deleted the mh/tst branch January 27, 2017 15:47
@olexandr-konovalov
Copy link
Member

On #1072, @alex-konovalov mentioned that the new testextra dir could be hooked up to be run by tst/teststandard.g. Sure, that's easy to do.

But has not been done. I will do this now. I will make a direct commit to master branch since this is not covered by Travis CI anyway.

@olexandr-konovalov
Copy link
Member

Done in 6c97733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: tests issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants