-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak tests a bit #1100
Tweak tests a bit #1100
Conversation
In particular, don't rely on printing polynomials, as the output of that can change when the indeterminates get a new name.
Current coverage is 54.32% (diff: 100%)@@ master #1100 diff @@
==========================================
Files 432 432
Lines 224765 224765
Methods 3431 3431
Messages 0 0
Branches 0 0
==========================================
- Hits 122572 122095 -477
- Misses 102193 102670 +477
Partials 0 0
|
On #1072, @alex-konovalov mentioned that the new As a matter of fact, I think we should rename the subdirs |
I shuld probably mention #790, which was a (failed) attempt to do what you propose. |
@markuspf Thanks for that pointer! Also https://github.com/gap-system/gap/wiki/Testing-methods-and-targets. I'll see what I can do. |
This is all totally fine. Will merge later unless anyone raises issues. There are obvious followups to come -- but this can be merged as is for now. |
But has not been done. I will do this now. I will make a direct commit to master branch since this is not covered by Travis CI anyway. |
Done in 6c97733 |
While working on removing GAPstones (see PR #1072), I made some tweaks and improvements to various tests, mainly to speed them up. I figured we might want to merge this workindependently of the GAPstones removal. In particular, it should be uncontroversial, which the removal of GAPstones might not be.