Skip to content

Commit

Permalink
kernel: cleanup vararg argument names (#5821)
Browse files Browse the repository at this point in the history
The kernel automatically adds the `...` so we don't have to do it.

Before:

    gap> Print;
    function( arg...... ) ... end

After

    gap> Print;
    function( arg... ) ... end

Since this is a purely cosmetic triviality I am not bothering
to add a test.
  • Loading branch information
fingolfin authored Oct 24, 2024
1 parent 11a8e61 commit ee6111c
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion src/gvars.c
Original file line number Diff line number Diff line change
Expand Up @@ -1419,7 +1419,7 @@ static StructGVarFunc GVarFuncs[] = {
GVAR_FUNC_1ARGS(MakeConstantGVar, name),
GVAR_FUNC_1ARGS(IsReadOnlyGVar, name),
GVAR_FUNC_1ARGS(IsConstantGVar, name),
GVAR_FUNC_XARGS(AUTO, -3, "func, arg, names..."),
GVAR_FUNC_XARGS(AUTO, -3, "func, arg, names"),

GVAR_FUNC_1ARGS(DeclareGlobalName, name),

Expand Down
6 changes: 3 additions & 3 deletions src/hpc/threadapi.c
Original file line number Diff line number Diff line change
Expand Up @@ -2536,11 +2536,11 @@ static StructGVarFunc GVarFuncs[] = {
GVAR_FUNC_1ARGS(SyncRead, syncvar),
GVAR_FUNC_1ARGS(SyncIsBound, syncvar),
GVAR_FUNC_1ARGS(IS_LOCKED, obj),
GVAR_FUNC_XARGS(LOCK, -1, "obj, ..."),
GVAR_FUNC_XARGS(DO_LOCK, -1, "obj, ..."),
GVAR_FUNC_XARGS(LOCK, -1, "obj"),
GVAR_FUNC_XARGS(DO_LOCK, -1, "obj"),
GVAR_FUNC_1ARGS(WRITE_LOCK, obj),
GVAR_FUNC_1ARGS(READ_LOCK, obj),
GVAR_FUNC_XARGS(TRYLOCK, -1, "obj, ..."),
GVAR_FUNC_XARGS(TRYLOCK, -1, "obj"),
GVAR_FUNC_1ARGS(UNLOCK, sp),
GVAR_FUNC_0ARGS(CURRENT_LOCKS),
GVAR_FUNC_1ARGS(REFINE_TYPE, obj),
Expand Down
10 changes: 5 additions & 5 deletions src/streams.c
Original file line number Diff line number Diff line change
Expand Up @@ -1703,11 +1703,11 @@ static StructGVarFunc GVarFuncs[] = {
GVAR_FUNC_1ARGS(OUTPUT_LOG_TO, filename),
GVAR_FUNC_1ARGS(OUTPUT_LOG_TO_STREAM, filename),
GVAR_FUNC_0ARGS(CLOSE_OUTPUT_LOG_TO),
GVAR_FUNC_XARGS(Print, -1, "arg..."),
GVAR_FUNC_XARGS(PRINT_TO, -1, "arg..."),
GVAR_FUNC_XARGS(PRINT_TO_STREAM, -1, "arg..."),
GVAR_FUNC_XARGS(APPEND_TO, -1, "arg..."),
GVAR_FUNC_XARGS(APPEND_TO_STREAM, -1, "arg..."),
GVAR_FUNC_XARGS(Print, -1, "arg"),
GVAR_FUNC_XARGS(PRINT_TO, -1, "arg"),
GVAR_FUNC_XARGS(PRINT_TO_STREAM, -1, "arg"),
GVAR_FUNC_XARGS(APPEND_TO, -1, "arg"),
GVAR_FUNC_XARGS(APPEND_TO_STREAM, -1, "arg"),
GVAR_FUNC_0ARGS(TmpName),
GVAR_FUNC_0ARGS(TmpDirectory),
GVAR_FUNC_1ARGS(RemoveFile, filename),
Expand Down
6 changes: 3 additions & 3 deletions src/tietze.c
Original file line number Diff line number Diff line change
Expand Up @@ -1573,9 +1573,9 @@ static StructGVarFunc GVarFuncs[] = {
GVAR_FUNC_1ARGS(TzRenumberGens, tietze),
GVAR_FUNC_1ARGS(TzReplaceGens, tietze),
GVAR_FUNC_3ARGS(TzSubstituteGen, tietze, gennum, word),
GVAR_FUNC_XARGS(TzOccurrences, -1, "arg..."),
GVAR_FUNC_XARGS(TzOccurrencesPairs, -1, "arg..."),
GVAR_FUNC_XARGS(TzSearchC, -1, "arg..."),
GVAR_FUNC_XARGS(TzOccurrences, -1, "arg"),
GVAR_FUNC_XARGS(TzOccurrencesPairs, -1, "arg"),
GVAR_FUNC_XARGS(TzSearchC, -1, "arg"),
GVAR_FUNC_2ARGS(REDUCE_LETREP_WORDS_REW_SYS, tzwords, word),
{ 0, 0, 0, 0, 0 }

Expand Down

0 comments on commit ee6111c

Please sign in to comment.