Downrank MatrixObj methods to unbreak Semigroups

gap-system · Sep 5, 2018 · ab46263 · ab46263
1 parent e628410
commit ab46263
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/matobj.gi b/lib/matobj.gi
@@ -179,6 +179,9 @@ InstallMethod( Matrix,
 #
 InstallMethod( Matrix,
   [IsSemiring, IsList, IsInt],
+  # FIXME: Remove this downranking, it was introduced to prevent
+  #        Semigroups from breaking ahead of the 4.10 release
+  -SUM_FLAGS,
   function( basedomain, list, nrCols )
     local rep;
     rep := DefaultMatrixRepForBaseDomain(basedomain);
@@ -187,6 +190,9 @@ InstallMethod( Matrix,
 
 InstallMethod( Matrix,
   [IsSemiring, IsList],
+  # FIXME: Remove this downranking, it was introduced to prevent
+  #        Semigroups from breaking ahead of the 4.10 release
+  -SUM_FLAGS,
   function( basedomain, list )
     local rep;
     if Length(list) = 0 then Error("list must be not empty"); fi;
@@ -196,6 +202,9 @@ InstallMethod( Matrix,
 
 InstallMethod( Matrix,
   [IsSemiring, IsMatrixObj],
+  # FIXME: Remove this downranking, it was introduced to prevent
+  #        Semigroups from breaking ahead of the 4.10 release
+  -SUM_FLAGS,
   function( basedomain, mat )
     # TODO: can we do better? encourage MatrixObj implementors to overload this?
     return NewMatrix( DefaultMatrixRepForBaseDomain(basedomain), basedomain, NrCols(mat), Unpack(mat) );

diff --git a/lib/matrix.gi b/lib/matrix.gi
@@ -1222,6 +1222,9 @@ end );
 InstallOtherMethod( BaseDomain,
     "generic method for a row vector",
     [ IsRowVector ],
+    # FIXME: Remove this downranking, it was introduced to prevent
+    #        Semigroups from breaking ahead of the 4.10 release
+    -SUM_FLAGS,
     DefaultRing );
 
 InstallOtherMethod( OneOfBaseDomain,
@@ -1249,7 +1252,6 @@ InstallOtherMethod( ZeroOfBaseDomain,
     [ IsMatrix and IsPlistRep ],
     mat -> Zero( mat[1,1] ) );
 
-
 #############################################################################
 ##
 #M  DepthOfUpperTriangularMatrix( <mat> )