Skip to content

Commit

Permalink
Make WreathProductElementList for Matrix Wreath Product faster.
Browse files Browse the repository at this point in the history
Use `BlockMatrix` instead of computing a product and embeddings.

At the moment we use `MatrixByBlockMatrix` to convert `BlockMatrix` to `IsOrdinaryMatrix`.
Without conversion we get errors.
  • Loading branch information
FriedrichRober committed Jun 14, 2021
1 parent 02437f4 commit 9f2d5cf
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/gprdmat.gi
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,8 @@ function(G, list)
local info;

info := WreathProductInfo(G);
return Product(List([1 .. info.degI + 1], i -> list[i] ^ Embedding(G, i)));
# TODO: Remove `MatrixByBlockMatrix` when `BlockMatrix` supports the MatObj interface.
return MatrixByBlockMatrix(BlockMatrix(List([1 .. info.degI], i -> [i, i ^ list[info.degI + 1], list[i]]), info.degI, info.degI));
end);

# tensor wreath -- dimension d^e This is not a faithful representation of
Expand Down

0 comments on commit 9f2d5cf

Please sign in to comment.