Skip to content

Commit

Permalink
ENHANCE: CharacteristicSubgroupsLib to CharacteristicSubgroups
Browse files Browse the repository at this point in the history
  • Loading branch information
hulpke authored and fingolfin committed Dec 7, 2016
1 parent 40165cb commit 9a36e8c
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions lib/autsr.gi
Original file line number Diff line number Diff line change
Expand Up @@ -832,9 +832,9 @@ local d,a,map,possibly,cG,cH,nG,nH,i,j,sel,u,v,asAutomorphism,K,L,conj,e1,e2,
# go through factors of characteristic series to keep orbits short.
AutomorphismGroup(G:someCharacteristics:=fail);
AutomorphismGroup(H:someCharacteristics:=fail);
cG:=CharacteristicSubgroupsLib(G);
cG:=CharacteristicSubgroups(G);
nG:=[];
cH:=ShallowCopy(CharacteristicSubgroupsLib(H));
cH:=ShallowCopy(CharacteristicSubgroups(H));
if Length(cG)<>Length(cH) then
return fail;
fi;
Expand Down
8 changes: 4 additions & 4 deletions lib/grp.gd
Original file line number Diff line number Diff line change
Expand Up @@ -1845,11 +1845,11 @@ DeclareAttribute( "NormalSubgroups", IsGroup );

#############################################################################
##
#A CharacteristicSubgroupsLib( <G> )
#A CharacteristicSubgroups( <G> )
##
## <#GAPDoc Label="CharacteristicSubgroupsLib">
## <#GAPDoc Label="CharacteristicSubgroups">
## <ManSection>
## <Attr Name="CharacteristicSubgroupsLib" Arg='G'/>
## <Attr Name="CharacteristicSubgroups" Arg='G'/>
##
## <Description>
## returns a list of all characteristic subgroups of <A>G</A>, that is
Expand All @@ -1864,7 +1864,7 @@ DeclareAttribute( "NormalSubgroups", IsGroup );
## </ManSection>
## <#/GAPDoc>
##
DeclareAttribute( "CharacteristicSubgroupsLib", IsGroup );
DeclareAttribute( "CharacteristicSubgroups", IsGroup );


#############################################################################
Expand Down
4 changes: 2 additions & 2 deletions lib/grp.gi
Original file line number Diff line number Diff line change
Expand Up @@ -5140,9 +5140,9 @@ end);

#############################################################################
##
#M CharacteristicSubgroupsLib( <G> )
#M CharacteristicSubgroups( <G> )
##
InstallMethod(CharacteristicSubgroupsLib,"use automorphisms",true,[IsGroup],
InstallMethod(CharacteristicSubgroups,"use automorphisms",true,[IsGroup],
G->Filtered(NormalSubgroups(G),x->IsCharacteristicSubgroup(G,x)));

InstallTrueMethod( CanComputeSize, HasSize );
Expand Down
2 changes: 1 addition & 1 deletion lib/grpnames.gi
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ InstallMethod(CharacteristicFactorsOfGroup, "generic method", true,
function(G)
local Ns,MinNs,sel,a,sz,j,gs,g,N;

Ns := ShallowCopy(CharacteristicSubgroupsLib(G));
Ns := ShallowCopy(CharacteristicSubgroups(G));
SortBy(Ns,Size);
MinNs:=[];
sel:=[2..Length(Ns)-1];
Expand Down
4 changes: 2 additions & 2 deletions lib/grppclat.gi
Original file line number Diff line number Diff line change
Expand Up @@ -1195,9 +1195,9 @@ end);

#############################################################################
##
#M CharacteristicSubgroupsLib( <G> )
#M CharacteristicSubgroups( <G> )
##
InstallMethod(CharacteristicSubgroupsLib,"solvable, automorphisms",true,
InstallMethod(CharacteristicSubgroups,"solvable, automorphisms",true,
[IsGroup and IsSolvableGroup],0,
function(G)
local A,s;
Expand Down

0 comments on commit 9a36e8c

Please sign in to comment.