Skip to content

Commit

Permalink
MinimalGeneratingSet for solvable non-pc groups
Browse files Browse the repository at this point in the history
  • Loading branch information
hulpke authored and fingolfin committed Apr 21, 2022
1 parent a5ddf8c commit 97feedb
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 16 deletions.
16 changes: 8 additions & 8 deletions lib/grp.gi
Original file line number Diff line number Diff line change
Expand Up @@ -107,21 +107,21 @@ end);
##
#M MinimalGeneratingSet(<G>) . . . . . . . . . . . . . for groups
##
InstallMethod(MinimalGeneratingSet,"solvable group via pc",true,
[IsGroup],0,
InstallMethod(MinimalGeneratingSet,"test solvable and 2-generator noncyclic",
true, [IsGroup and IsFinite],0,
function(G)
local i;
if not IsSolvableGroup(G) then
if IsGroup(G) and HasGeneratorsOfGroup(G)
if not HasIsSolvableGroup(G) and IsSolvableGroup(G) and
CanEasilyComputePcgs(G) then
# discovered solvable -- redo
return MinimalGeneratingSet(G);
elif not IsSolvableGroup(G) then
if IsGroup(G) and (not IsCyclic(G)) and HasGeneratorsOfGroup(G)
and Length(GeneratorsOfGroup(G)) = 2 then
return GeneratorsOfGroup(G);
fi;
TryNextMethod();
fi;
i:=IsomorphismPcGroup(G);
G:=Image(i,G);
G:=MinimalGeneratingSet(G);
return List(G,j->PreImagesRepresentative(i,j));
end);

#############################################################################
Expand Down
11 changes: 3 additions & 8 deletions lib/grppcatr.gi
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ end;
##
InstallMethod( MinimalGeneratingSet,
"pcgs computable groups using special pcgs",
true, [ IsPcGroup and IsFinite ], 0,
true, [ IsSolvableGroup and IsFinite and CanEasilyComputePcgs], 0,

function( G )
local spec, weights, first, m, mingens, i, start, next, j,
Expand Down Expand Up @@ -662,13 +662,8 @@ end );
#M SmallGeneratingSet(<G>)
##
InstallMethod(SmallGeneratingSet,"using minimal generating set",true,
[IsPcGroup and IsFinite],0,
function (G)
if Length(Pcgs(G))>14 then
TryNextMethod();
fi;
return MinimalGeneratingSet(G);
end);
[IsSolvableGroup and IsFinite and CanEasilyComputePcgs],0,
MinimalGeneratingSet);

#############################################################################
##
Expand Down

0 comments on commit 97feedb

Please sign in to comment.