Skip to content

Commit

Permalink
FIX: Removed dodgy redundant structure settings.
Browse files Browse the repository at this point in the history
This resolves #3634
  • Loading branch information
hulpke committed Aug 30, 2019
1 parent 0046be1 commit 3a54bcd
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions lib/ghomfp.gi
Original file line number Diff line number Diff line change
Expand Up @@ -1090,11 +1090,11 @@ local m,s,g,i,j,rel,gen,img,fin,hom,gens;
Add(rel,g.(i)^s.normal[i][i]);
od;
Append(img,ListWithIdenticalEntries(Length(gen)-s.rank,0));
SetAbelianInvariants(f,img);
g:=g/rel;
fin:=false;
else
SetAbelianInvariants(f,DiagonalOfMat(s.normal));
# Not `AbelianInvariantsOfList' as the structure of the group is as
# given by the normal form
g:=AbelianGroup(DiagonalOfMat(s.normal));
fin:=true;
fi;
Expand Down Expand Up @@ -1207,6 +1207,8 @@ local aug,r,sec,t,expwrd,rels,ab,s,m,img,gen,i,j,t1,t2,tn;
# TODO: Reproduce creation of infinite abelian group
TryNextMethod();
else
# Not `AbelianInvariantsOfList' as the structure of the group is as
# given by the normal form
ab:=AbelianGroup(DiagonalOfMat(s.normal));
fi;
gen:=GeneratorsOfGroup(ab);
Expand Down

0 comments on commit 3a54bcd

Please sign in to comment.