Skip to content

Commit

Permalink
Replace CommutatorFactorGroup by MaximalAbelianQuotient
Browse files Browse the repository at this point in the history
  • Loading branch information
hungaborhorvath committed Feb 11, 2016
1 parent 29f6920 commit 2b0f3c7
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions lib/grp.gi
Original file line number Diff line number Diff line change
Expand Up @@ -1018,7 +1018,7 @@ InstallMethod( FrattiniSubgroup, "generic method for nilpotent groups",
RankFilter( IsGroup and IsNilpotentGroup )
- RankFilter( IsGroup ),
function(G)
local i, abinv, indgen, p, q, gen, Gf;
local i, abinv, indgen, p, q, gen, hom, Gf;
if IsTrivial(G) then
return G;
elif IsAbelian(G) then
Expand All @@ -1034,8 +1034,10 @@ local i, abinv, indgen, p, q, gen, Gf;
od;
return SubgroupNC(G, gen);
elif IsNilpotentGroup(G) then
Gf := CommutatorFactorGroup(G);
return PreImage(NaturalHomomorphism(Gf), FrattiniSubgroup(Gf));
hom := MaximalAbelianQuotient(G);
Gf := Image(hom);
SetIsAbelian(Gf, true);
return PreImage(hom, FrattiniSubgroup(Gf));
else
TryNextMethod();
fi;
Expand Down

0 comments on commit 2b0f3c7

Please sign in to comment.