Merge pull request #2938 from ThomasBreuer/TB_RealPart

fixed `ImaginaryPart` for quaternion algebras
gap-system · Oct 24, 2018 · 26b88ca · 26b88ca
2 parents 1fe546e + eed628a
commit 26b88ca
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/lib/algsc.gi b/lib/algsc.gi
@@ -884,11 +884,12 @@ InstallMethod( ImaginaryPart,
     "for a quaternion",
     [ IsQuaternion and IsSCAlgebraObj ],
     function( quat )
-    local v, z;
+    local v, z, a;
 
     v:= ExtRepOfObj( quat );
     z:= Zero( v[1] );
-    return ObjByExtRep( FamilyObj( quat ), [ v[2], z, v[4], -v[3] ] );
+    a:= FamilyObj( quat )!.sctable[2][2][2][1];  # the first parameter
+    return ObjByExtRep( FamilyObj( quat ), [ v[2], z, -v[4], -v[3]/a ] );
     end );
 
 

diff --git a/tst/testinstall/algsc.tst b/tst/testinstall/algsc.tst
@@ -107,6 +107,22 @@ gap> v:= Subspace( a, [ v, 0*v, v^0, w ] );
 gap> Dimension( v );
 3
 
+#
+gap> a:= QuaternionAlgebra( Rationals, -2, -3 );;
+gap> gens:= GeneratorsOfAlgebra( a );
+[ e, i, j, k ]
+gap> List( gens, RealPart );
+[ e, 0*e, 0*e, 0*e ]
+gap> List( gens, ImaginaryPart ) * gens[2];
+[ 0*e, i, j, k ]
+gap> vecs := Concatenation( gens, [ Sum( gens ) ] );
+[ e, i, j, k, e+i+j+k ]
+gap> ForAll( vecs, v -> (v + ComplexConjugate( v )) / 2 = RealPart( v ) );
+true
+gap> ForAll( vecs, v -> (v - ComplexConjugate( v )) / (2*gens[2])
+>                       = ImaginaryPart( v ) );
+true
+
 #############################################################################
 ##
 ##  Expl. 1: $2.A6$, gen. by 20 quaternionic reflections over $H(\sqrt{3})$