Skip to content

Commit

Permalink
kernel: mark GenStackFuncBags as NOINLINE
Browse files Browse the repository at this point in the history
Inlining this function can break the garbage collector. This was the case on
Linux aarch64.

Thanks to Jerry James (Fedora) and Bill Allombert (Debian) for help tracking
this down.

Fixes #3919
  • Loading branch information
fingolfin committed Apr 17, 2020
1 parent 739d309 commit 0956ce6
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/gasman.c
Original file line number Diff line number Diff line change
Expand Up @@ -1779,8 +1779,7 @@ static void SparcStackFuncBags(void)
}
#endif


static void GenStackFuncBags(void)
static NOINLINE void GenStackFuncBags(void)
{
Bag * top; /* top of stack */
Bag * p; /* loop variable */
Expand Down

0 comments on commit 0956ce6

Please sign in to comment.