Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[semigroups] Update to 5.3.1 #833

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[semigroups] Update to 5.3.1 #833

merged 1 commit into from
Sep 19, 2023

Conversation

gap-package-distribution-bot[bot]
Copy link
Contributor

@gap-package-distribution-bot gap-package-distribution-bot bot commented Sep 18, 2023 •
edited
Loading

@gap-package-distribution-bot gap-package-distribution-bot bot added automated pr Automatically applied to PRs created by a GH workflow package update labels Sep 18, 2023
@gap-package-distribution-bot
Copy link
Contributor Author

gap-package-distribution-bot bot commented Sep 18, 2023 •
edited
Loading

Package Evaluation Report for GAP master

Job Properties

Testing: master/2023-09-19-17:10:07-7d2911f6 vs master/2023-09-19-09:09:26-bdd1fc9c

Generated by Workflow: https://github.com/gap-system/PackageDistro/actions/runs/6238156582

In total, 156 packages were tested, out of which 152 succeeded, 0 failed and 4 were skipped.

✔️ Packages still succeeding

152 package(s) succeeded tests also on the previous version.

Click to show packages!

➖ Packages that were skipped

4 package(s) skipped tests also on the previous version.

Click to show packages!

@fingolfin
Copy link
Member

@james-d-mitchell unfortunately the new Semigroups 5.3.0 experiences a hard fail here:

#I  Semigroups: start reading file 'init.g'
Error, LOAD_DYN: failed to load kernel module /home/runner/gap/pkg/semigroups-5.3.0//\
bin/x86_64-pc-linux-gnu-default64-kv9/semigroups.so, libsemigroups.so.2: canno\
t open shared object file: No such file or directory in
  LOAD_DYN( filename ) at /home/runner/gap/lib/files.gd:594 called from

I have not yet had time to dig deeper, but I will.

@fingolfin
Copy link
Member

Ah, Semigroups does this:

ifdef WITH_INCLUDED_LIBSEMIGROUPS
KEXT_LDFLAGS += -Wl,-rpath,bin/lib

But that's using a relative path, which is no good in general. Perhaps something like this would work (untested!)

ifdef WITH_INCLUDED_LIBSEMIGROUPS
KEXT_LDFLAGS += -Wl,-rpath,$PWD/bin/lib

@james-d-mitchell james-d-mitchell mentioned this pull request Sep 19, 2023
Merged
@gap-package-distribution-bot gap-package-distribution-bot bot changed the title [semigroups] Update to 5.3.0 [semigroups] Update to 5.3.1 Sep 19, 2023
@fingolfin
Copy link
Member

Yay, 5.3.1 works!

@fingolfin fingolfin merged commit 64ef65f into main Sep 19, 2023
309 of 310 checks passed
@fingolfin fingolfin deleted the automatic/semigroups branch September 19, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
automated pr Automatically applied to PRs created by a GH workflow package update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fingolfin