added operations for a module as an algebra #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
XModAlgebraByModule has been rewritten and examples added to the manual - XModAlgebra X3 and its conversion to a Cat1-algebraC3. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #75 +/- ##
==========================================
+ Coverage 69.57% 71.33% +1.76%
==========================================
Files 8 10 +2
Lines 2491 2512 +21
==========================================
+ Hits 1733 1792 +59
+ Misses 758 720 -38
|
|
Removed use of AlgebraHomomorphismByFunction because CI tests with stable-4.12 were failing. |
|
Extensive changes in this PR. The main change is the revised module action, with added files module.gd, module.gi, module3.tst. What is now needed is a revision of AlgebraAction2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code for AlgebraActionByModule used Cartesian, an operation best avoided.
This PR adds functions: ModuleAsAlgebra, IsModuleAsAlgebra, ModuleToAlgebraIsomorphism and AlgebraToModuleIsomorphism and rewrites AlgebraActionByModule.
The next step will be to rewrite XModAlgebraByModule.