now AlgebraHomomorphismByFunction2 avoiding conflict with FR

[cdwensley]

Alex K. has reported XModAlg segfaulting with AllPackagesLoaded.
Possibly this is due to AlgebraHomomorphismByFunction being defined in different ways in FR and XModAlg. This temporary fix renames the XModAlg version AlgebraHomomorphismByFunction2.

[cdwensley]

In the longer term it appears that AlgebraHomomorphismByFunction is of general interest and would be better moved to Utils - will contact Laurent about this.

[codecov]

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is 25%.

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   43.51%   43.51%           
=======================================
  Files           4        4           
  Lines        2574     2574           
=======================================
  Hits         1120     1120           
  Misses       1454     1454

Impacted Files	Coverage Δ
lib/alg2obj.gi	55.38% <25%> (ø)	⬆️

[olexandr-konovalov]

I am afraid this will mask some problem that was introduced in the core GAP system yesterday. There was no new FR release, and all tests worked a day before. Perhaps you've now report the problem at gap-system/gap#2401 ?

[cdwensley]

So this PR should NOT be merged (at present).
No idea what the codecov/patch check failure is.

[olexandr-konovalov]

@cdwensley codecov complains that the coverage of the changed code is lower (25%) then the overall code coverage of the package code (43.51%). It's for package maintainer to decide whether to ignore this for now or add more tests.

[cdwensley]

Whatever the problem was, it was not the fault of XModAlg, so closing this PR.