Merge pull request #12 from cdwensley/zero

adjust tests to work after LoadAllPackages(); closes #2
gap-packages · Dec 2, 2017 · 5507768 · 5507768
2 parents 90cdaeb + ae8acb0
commit 5507768
Show file tree

Hide file tree

Showing 5 changed files with 39 additions and 24 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,6 +1,7 @@
 # CHANGES to the 'XModAlg' package
 
 ## 1.13 -> 1.14 
+ * (02/12/17) adjust test files to work correctly after LoadAllPackages(); 
  * (30/11/17) now requires XMod 2.64 
  * (01/11/17) now requires Laguna 3.7.0 
  * (05/10/17) moved testall.g to testing.g and added new testall.g 

diff --git a/PackageInfo.g b/PackageInfo.g
@@ -9,15 +9,15 @@ PackageName := "XModAlg",
 Subtitle := "Crossed Modules and Cat1-Algebras",
 
 Version := "1.14",
-Date := "30/11/2017",
+Date := "02/12/2017",
 
 ##  duplicate these values for inclusion in the manual: 
 ##  <#GAPDoc Label="PKGVERSIONDATA">
 ##  <!ENTITY VERSION "1.14">
 ##  <!ENTITY ZIPFILENAME "xmodalg-1.14.zip">
 ##  <!ENTITY HTMLFILENAME "xmodalg114.html">
-##  <!ENTITY RELEASEDATE "30/11/2017">
-##  <!ENTITY LONGRELEASEDATE "30th November 2017">
+##  <!ENTITY RELEASEDATE "02/12/2017">
+##  <!ENTITY LONGRELEASEDATE "2nd December 2017">
 ##  <!ENTITY COPYRIGHTYEARS "2014-2017">
 ##  <#/GAPDoc>
 

diff --git a/lib/alg2map.gi b/lib/alg2map.gi
@@ -146,7 +146,7 @@ InstallMethod( Display, "display a morphism of pre-crossed modules", true,
     [ IsPreXModAlgebraMorphism ], 0,
     function( mor )
 
-    local  morsrc, morrng, gensrc, genrng, P, Q, name, ok;	
+    local morsrc, morrng, gensrc, genrng, imsrc, imrng, P, Q, name, ok;	
     name := Name( mor );
     P := Source( mor );
     Q := Range( mor );
@@ -168,11 +168,13 @@ InstallMethod( Display, "display a morphism of pre-crossed modules", true,
         Print( GeneratorsOfAlgebra( Source( Q ) ), "\n" );
         Print( "  ", GeneratorsOfAlgebra( Range( Q ) ), "\n" );
     fi;
+    imsrc := List( gensrc, s -> Image( morsrc, s ) ); 
     Print( ": Source Homomorphism maps source generators to:\n" );
-    Print( "  ", List( gensrc, s -> Image( morsrc, s ) ), "\n" );
+    Print( "  ", imsrc, "\n" );
+    imrng := List( genrng, r -> Image( morrng, r ) ); 
     Print( ": Range Homomorphism maps range generators to:\n" );
-    Print( "  ", List( genrng, r -> Image( morrng, r ) ), "\n" );
-	Print( "\n" );
+    Print( "  ", imrng, "\n" );
+    Print( "\n" );
 end ); 
 
 #############################################################################

diff --git a/tst/cat1.tst b/tst/cat1.tst
@@ -33,19 +33,29 @@ gap> A := GroupRing( GF(2), Group( (1,2,3)(4,5) ) );
 <algebra-with-one over GF(2), with 1 generators>
 gap> R := GroupRing( GF(2), Group( (1,2,3) ) );
 <algebra-with-one over GF(2), with 1 generators>
-gap> f := AllHomsOfAlgebras( A, R );
-[ [ (Z(2)^0)*(1,3,2)(4,5) ] -> [ <zero> of ... ], [ (Z(2)^0)*(1,3,2)(4,5) ] -> [ (Z(2)^0)*() ],
-  [ (Z(2)^0)*(1,3,2)(4,5) ] -> [ (Z(2)^0)*()+(Z(2)^0)*(1,2,3) ],
-  [ (Z(2)^0)*(1,3,2)(4,5) ] -> [ (Z(2)^0)*()+(Z(2)^0)*(1,2,3)+(Z(2)^0)*(1,3,2) ],
-  [ (Z(2)^0)*(1,3,2)(4,5) ] -> [ (Z(2)^0)*()+(Z(2)^0)*(1,3,2) ], [ (Z(2)^0)*(1,3,2)(4,5) ] -> [ (Z(2)^0)*(1,2,3) ],
-  [ (Z(2)^0)*(1,3,2)(4,5) ] -> [ (Z(2)^0)*(1,2,3)+(Z(2)^0)*(1,3,2) ], [ (Z(2)^0)*(1,3,2)(4,5) ] -> [ (Z(2)^0)*(1,3,2)
-     ] ]
-gap> g := AllHomsOfAlgebras( R, A );
-[ [ (Z(2)^0)*(1,2,3) ] -> [ <zero> of ... ], [ (Z(2)^0)*(1,2,3) ] -> [ (Z(2)^0)*() ],
-  [ (Z(2)^0)*(1,2,3) ] -> [ (Z(2)^0)*()+(Z(2)^0)*(1,2,3) ],
-  [ (Z(2)^0)*(1,2,3) ] -> [ (Z(2)^0)*()+(Z(2)^0)*(1,2,3)+(Z(2)^0)*(1,3,2) ],
-  [ (Z(2)^0)*(1,2,3) ] -> [ (Z(2)^0)*()+(Z(2)^0)*(1,3,2) ], [ (Z(2)^0)*(1,2,3) ] -> [ (Z(2)^0)*(1,2,3) ],
-  [ (Z(2)^0)*(1,2,3) ] -> [ (Z(2)^0)*(1,2,3)+(Z(2)^0)*(1,3,2) ], [ (Z(2)^0)*(1,2,3) ] -> [ (Z(2)^0)*(1,3,2) ] ]
+gap> f := AllHomsOfAlgebras( A, R );;
+gap> mgif := List( f, h -> MappingGeneratorsImages(h) );;
+gap> Print( mgif, "\n" );
+[ [ [ (Z(2)^0)*(1,3,2)(4,5) ], [ <zero> of ... ] ], 
+  [ [ (Z(2)^0)*(1,3,2)(4,5) ], [ (Z(2)^0)*() ] ], 
+  [ [ (Z(2)^0)*(1,3,2)(4,5) ], [ (Z(2)^0)*()+(Z(2)^0)*(1,2,3) ] ], 
+  [ [ (Z(2)^0)*(1,3,2)(4,5) ], 
+      [ (Z(2)^0)*()+(Z(2)^0)*(1,2,3)+(Z(2)^0)*(1,3,2) ] ], 
+  [ [ (Z(2)^0)*(1,3,2)(4,5) ], [ (Z(2)^0)*()+(Z(2)^0)*(1,3,2) ] ], 
+  [ [ (Z(2)^0)*(1,3,2)(4,5) ], [ (Z(2)^0)*(1,2,3) ] ], 
+  [ [ (Z(2)^0)*(1,3,2)(4,5) ], [ (Z(2)^0)*(1,2,3)+(Z(2)^0)*(1,3,2) ] ], 
+  [ [ (Z(2)^0)*(1,3,2)(4,5) ], [ (Z(2)^0)*(1,3,2) ] ] ]
+gap> g := AllHomsOfAlgebras( R, A );;
+gap> mgig := List( g, h -> MappingGeneratorsImages(h) );;
+gap> Print( mgig, "\n" );
+[ [ [ (Z(2)^0)*(1,2,3) ], [ <zero> of ... ] ], 
+  [ [ (Z(2)^0)*(1,2,3) ], [ (Z(2)^0)*() ] ], 
+  [ [ (Z(2)^0)*(1,2,3) ], [ (Z(2)^0)*()+(Z(2)^0)*(1,2,3) ] ], 
+  [ [ (Z(2)^0)*(1,2,3) ], [ (Z(2)^0)*()+(Z(2)^0)*(1,2,3)+(Z(2)^0)*(1,3,2) ] ],
+  [ [ (Z(2)^0)*(1,2,3) ], [ (Z(2)^0)*()+(Z(2)^0)*(1,3,2) ] ], 
+  [ [ (Z(2)^0)*(1,2,3) ], [ (Z(2)^0)*(1,2,3) ] ], 
+  [ [ (Z(2)^0)*(1,2,3) ], [ (Z(2)^0)*(1,2,3)+(Z(2)^0)*(1,3,2) ] ], 
+  [ [ (Z(2)^0)*(1,2,3) ], [ (Z(2)^0)*(1,3,2) ] ] ]
 gap> C4 := PreCat1ByTailHeadEmbedding( f[6], f[6], g[8] );
 [AlgebraWithOne( GF(2), [ (Z(2)^0)*(1,2,3)(4,5) ] ) -> AlgebraWithOne( GF(2), [ (Z(2)^0)*(1,2,3) ] )]
 gap> IsCat1Algebra( C4 );

diff --git a/tst/xmod.tst b/tst/xmod.tst
@@ -163,11 +163,13 @@ gap> Size( X3 );
 gap> IsSubXModAlgebra( X1, X3 );
 true
 
-## Chapter 2,  Section 2.2.3
+## Chapter 2,  Section 2.2.4
 
-gap> theta := SourceHom( mor );
-[ (Z(2)^0)*<identity> of ...+(Z(2)^0)*f2, (Z(2)^0)*f1+(Z(2)^0)*f2, (Z(2)^0)*f2+(Z(2)^0)*f1*f2 ] ->
-[ <zero> of ..., <zero> of ..., <zero> of ... ]
+gap> theta := SourceHom( mor );;
+gap> Print( MappingGeneratorsImages( theta ), "\n" ); 
+[ [ (Z(2)^0)*<identity> of ...+(Z(2)^0)*f2, (Z(2)^0)*f1+(Z(2)^0)*f2, 
+      (Z(2)^0)*f2+(Z(2)^0)*f1*f2 ], 
+  [ <zero> of ..., <zero> of ..., <zero> of ... ] ]
 gap> phi := RangeHom( mor );
 [ (Z(2)^0)*f1 ] -> [ (Z(2)^0)*<identity> of ... ]
 gap> IsInjective( mor );