Skip to content

Commit

Permalink
Merge pull request #66 from gap-packages/avoid
Browse files Browse the repository at this point in the history
avoid trivial function wrappers
  • Loading branch information
cdwensley authored Jan 6, 2024
2 parents bf372ad + 3158e58 commit f082355
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
6 changes: 6 additions & 0 deletions init.g
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@
if not IsBound( PreImagesRepresentativeNC ) then
BindGlobal( "PreImagesRepresentativeNC", PreImagesRepresentative );
fi;
if not IsBound( IsMatrixOrMatrixObj ) then
BindGlobal( "IsMatrixOrMatrixObj", IsMatrix );
fi;
if not IsBound( MutableCopyMatrix ) then
BindGlobal( "MutableCopyMatrix", ShallowCopy );
fi;

## read the function declarations

Expand Down
2 changes: 1 addition & 1 deletion lib/lcset.gi
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ InstallMethod( LeftCosetsNC, "generic", IsIdenticalObj, [ IsGroup, IsGroup ], 0,
function( G, U )
local L;
L := RightCosetsNC( G, U );
return List( L, rc -> Inverse( rc ) );
return List( L, Inverse );
end);


4 changes: 2 additions & 2 deletions lib/lists.gi
Original file line number Diff line number Diff line change
Expand Up @@ -279,8 +279,8 @@ function( G, H )
Error( "<H> must be a subgroup of <G>" );
fi;
R := RightCosets( G, H );
ER := List( R, x -> Elements( x ) );
EL := List( ER, C -> List( C, x -> x^(-1) ) );
ER := List( R, Elements );
EL := List( ER, C -> List( C, Inverse ) );
Info( InfoUtils, 3, "right cosets: ", ER );
Info( InfoUtils, 3, " left cosets: ", EL );
T := CommonRepresentatives( EL, ER );
Expand Down

0 comments on commit f082355

Please sign in to comment.