Accommodate correctly pluralized ViewStrings in GAP #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2020
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
=======================================
Coverage 31.97% 31.97%
=======================================
Files 19 19
Lines 3825 3825
=======================================
Hits 1223 1223
Misses 2602 2602 |
fingolfin
reviewed
Dec 18, 2020
wilfwilson
force-pushed
the
pluralize
branch
from
e588b16
to
21a6dfb
Compare
wilfwilson
force-pushed
the
pluralize
branch
2 times, most recently
from
a67c221
to
76ff50e
Compare
olexandr-konovalov
approved these changes
Apr 21, 2021
fingolfin
approved these changes
Apr 22, 2021
|
Someone should make a release with this at some point... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a future version of GAP, some nouns will be correctly pluralised to match their number. For example, the
ViewStringforCyclicGroup(3);will change from<pc group of size 3 with 1 generators>to<pc group of size 3 with 1 generator>.The changes in this PR maintain the backwards and forwards compatibility of this package with GAP. (As far as I can tell, only the change to the test file is absolutely necessary to maintain compatibility, but I thought why not change the
.mskfiles too.)See gap-system/gap#3992 and gap-system/gap#4050 for more context.