Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn IsDirectSumOfModules into a pure filter #16

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Turn IsDirectSumOfModules into a pure filter #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/chapter_right_modules.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ gap> N := RightModuleOverPathAlgebra(A,mat);
<Returns>the direct sum of the representations contained in the
list <Arg>L</Arg>.</Returns>
<Description>In addition three attributes are attached to the
result, <Ref Attr="IsDirectSumOfModules"/>, <Ref
result, <Ref Filt="IsDirectSumOfModules"/>, <Ref
Attr="DirectSumProjections"/> <Ref Attr="DirectSumInclusions"/>.
</Description>
</ManSection>
Expand Down Expand Up @@ -540,7 +540,7 @@ gap> N := RightModuleOverPathAlgebra(A,mat);
</ManSection>

<ManSection>
<Attr Name="IsDirectSumOfModules" Arg="M" Comm="for a PathAlgebraMatModule"/>
<Filt Name="IsDirectSumOfModules" Arg="M" Comm="for a PathAlgebraMatModule"/>
<Description>
Arguments: <Arg>M</Arg> -- a path algebra module (<C>PathAlgebraMatModule</C>).
<Br /></Description>
Expand Down
2 changes: 1 addition & 1 deletion lib/module.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ InstallTrueMethod( IsIndecomposableModule, IsSimpleQPAModule );
DeclareProperty( "IsSemisimpleModule", IsPathAlgebraMatModule );
InstallTrueMethod( IsSemisimpleModule, IsSimpleQPAModule );
DeclareOperation( "DirectSumOfQPAModules", [ IsList] );
DeclareAttribute( "IsDirectSumOfModules", IsPathAlgebraMatModule );
DeclareFilter( "IsDirectSumOfModules", IsPathAlgebraMatModule );
DeclareAttribute( "DirectSumProjections", IsPathAlgebraMatModule );
DeclareAttribute( "DirectSumInclusions", IsPathAlgebraMatModule );
DeclareOperation( "SupportModuleElement", [ IsRightAlgebraModuleElement ] );
Expand Down
21 changes: 1 addition & 20 deletions lib/module.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1907,7 +1907,7 @@ InstallMethod( DirectSumOfQPAModules,
Add( list_of_incls, RightModuleHomOverAlgebra( L[ i ], direct_sum, maps ) );
od;

SetIsDirectSumOfModules( direct_sum, true );
SetFilterObj( direct_sum, IsDirectSumOfModules );
SetDirectSumProjections( direct_sum, list_of_projs );
SetDirectSumInclusions( direct_sum, list_of_incls );

Expand All @@ -1919,25 +1919,6 @@ end
);


#######################################################################
##
#P IsDirectSumOfModules( <M> )
##
## <M> is a module over a path algebra. The function checks if the
## property "IsDirectSumOfModules" is set to true for M, and returns
## true if it is, and false if it is not. (Note that this is NOT a
## check for indecomposability.)
##
InstallMethod( IsDirectSumOfModules,
"for a module over a path algebra",
[ IsPathAlgebraMatModule ], 0,
function( M )

return "IsDirectSumOfModules" in KnownTruePropertiesOfObject(M);

end
);

#######################################################################
##
#O SupportModuleElement(<m>)
Expand Down