Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis & Codecov support, update README.md #17

Merged
merged 1 commit into from
Sep 27, 2018

Conversation

fingolfin
Copy link
Member

BTW, I find it confusing that there are both a README and a README.md. Perhaps they should/could be merged?

@codecov
Copy link

codecov bot commented Sep 27, 2018

Codecov Report

Merging #17 into master will increase coverage by 4.81%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   74.16%   78.97%   +4.81%     
==========================================
  Files          22       44      +22     
  Lines        7322     8882    +1560     
==========================================
+ Hits         5430     7015    +1585     
+ Misses       1892     1867      -25
Impacted Files Coverage Δ
gap/affine.gd 100% <0%> (ø)
gap/catenary-tame.gd 100% <0%> (ø)
gap/good-ideals.gd 100% <0%> (ø)
gap/affine-def.gd 100% <0%> (ø)
gap/operations.gd 100% <0%> (ø)
gap/dot.gd 100% <0%> (ø)
gap/numsgps-utils.gd 100% <0%> (ø)
gap/numsgp-def.gd 100% <0%> (ø)
gap/ideals-def.gd 100% <0%> (ø)
gap/random.gd 100% <0%> (ø)
... and 34 more

@fingolfin
Copy link
Member Author

That code coverage increased is not due to this PR, but rather due to a change we just merged to GAP itself: gap-system/gap#2772

@pedritomelenas pedritomelenas merged commit bb2b9e6 into gap-packages:master Sep 27, 2018
@pedritomelenas
Copy link
Contributor

Thanks for the changes, @fingolfin

@pedritomelenas
Copy link
Contributor

We should delete probably README...

@fingolfin fingolfin deleted the mh/travis branch September 27, 2018 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants