Avoid incorrect pluralizations in test output #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
==========================================
+ Coverage 92.73% 93.04% +0.30%
==========================================
Files 7 7
Lines 633 661 +28
==========================================
+ Hits 587 615 +28
Misses 46 46
|
30 tasks
olexandr-konovalov
approved these changes
Jun 26, 2020
fingolfin
approved these changes
Jul 24, 2020
| @@ -36,9 +36,11 @@ false | |||
| # | |||
| gap> g9 := ReducibleNilpotentMatGroup(2,36,5,2); | |||
| <matrix group with 21 generators> | |||
| gap> SylowSubgroupsOfNilpotentFFMatGroup(g9); | |||
| [ <matrix group with 5 generators>, <matrix group with 6 generators>, | |||
| <matrix group with 1 generators> ] | |||
There was a problem hiding this comment.
Strictly speaking this test/example is taken from the manual (hence the name manual.tst). But I don't see a major issue with that shrug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable backwards and forwards compatibility of the test files with GAP when gap-system/gap#4050 is merged, which will cause things like
<matrix group with 1 generators>to show as<matrix group with 1 generator>.