Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CI to use GitHub Actions #28

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Conversation

fingolfin
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #28 (eb3cfdb) into master (5bac367) will decrease coverage by 3.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   36.11%   32.60%   -3.52%     
==========================================
  Files          39        9      -30     
  Lines       21111     6868   -14243     
==========================================
- Hits         7625     2239    -5386     
+ Misses      13486     4629    -8857     
Impacted Files Coverage Δ
standalone/lib/fsawa.c
standalone/src/gpaxioms.c
standalone/lib/fsaminkb.c
standalone/lib/fsatriples.c
standalone/lib/hash.c
standalone/lib/rabkar.c
standalone/lib/fsaio.c
standalone/lib/rwsiob.c
standalone/lib/rwsreduce.c
standalone/lib/migmdet.c
... and 22 more

@fingolfin fingolfin force-pushed the mh/travis-to-gh-actions branch 2 times, most recently from d34ff50 to b747e91 Compare April 6, 2021 21:54
@fingolfin fingolfin force-pushed the mh/travis-to-gh-actions branch from b747e91 to eb3cfdb Compare April 6, 2021 22:06
@fingolfin
Copy link
Member Author

fingolfin commented Apr 6, 2021

Unfortunately this loses coverage tracking for the standalone C code. I've not yet managed to re-enable it (see also PR #29).

@fingolfin
Copy link
Member Author

I verified in the logs that all files are compiled and linked with the --coverage option. But in the logs uploaded to Codecov, the "reduced" coverage info is zero. E.g. for standalone/lib/fsawa.c we get

# path=fsawa.c.gcov.reduced
        -:    0:Source:fsawa.c
<<<<<< EOF

yet also

./standalone/lib/fsawa.c:39,45,51,54,61,62,65,74,80,81,85,89,90,97,101,107,108,113,114,119,124,132,146,150,153,159,175,183,222,224,233,236,243,245,250,251,254,259,276,280,281,290,293,297,299,303,306,312,316,321,323,325,326,329,338,344,345,349,353,354,361,365,371,372,377,378,383,388,396,410,414,417,423,439,447,486,488,497,500,507,509,514,515,518,523,540,544,545,554,557,561,563,567,570,576,580,585,587,589

In the build logs, we see:

...
==> Running gcov in . (disable via -X gcov)
./standalone/lib/nfa.gcda:cannot open data file, assuming not executed
./standalone/lib/fsageopairs.gcda:cannot open data file, assuming not executed
./standalone/lib/diffredwl.gcda:cannot open data file, assuming not executed
./standalone/lib/fsarevmid.gcda:cannot open data file, assuming not executed
./standalone/lib/fsasubmult.gcda:cannot open data file, assuming not executed
...
Cannot open source file fsa.c
Cannot open source file nfa.c
Cannot open source file fsageopairs.c
Cannot open source file diffredwl.c
Cannot open source file fsarevmid.c
...
File 'fsawa.c'
Lines executed:40.91% of 330
Branches executed:43.57% of 280
Taken at least once:31.79% of 280
Calls executed:22.89% of 83
Creating 'fsawa.c.gcov'
...
Cannot open source file fsasubmult.c
Cannot open source file kbfns.c
Cannot open source file migmdet.c
Cannot open source file fsawa.c
...

So I am guessing it is confused about how to find the source files. But I wonder why?!? Esp. since it used to work fine when we used basically the same scripts on Travis... weird.

@fingolfin fingolfin merged commit ba01100 into master Apr 14, 2021
@fingolfin fingolfin deleted the mh/travis-to-gh-actions branch April 14, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant