Remove bad implication IsLinearCodeRep => IsCodeDefaultRep #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite its misleading name, IsLinearCodeRep is not a representation but rather a plain filter. As such, it should not imply a representation, as any object, with an arbitrary representation, may have this filter set. Besides removing the implication, we also need to adjust code that relied on it before.
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
- Coverage 48.73% 48.11% -0.62%
==========================================
Files 82 82
Lines 19562 20246 +684
==========================================
+ Hits 9533 9742 +209
- Misses 10029 10504 +475
|
|
@osj1961 Does this look reasonable to you? |
|
@osj1961 ping? |
|
@osj1961 Joe, is there any reason not to merge this? |
|
Sorry, I wanted to really understand what this PR was about. I still don't, but as the checks all pass I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite its misleading name, IsLinearCodeRep is not a representation but rather a plain filter. As such, it should not imply a representation, as any object, with an arbitrary representation, may have this filter set.
Besides removing the implication, we also need to adjust code that relied on it before.
In future GAP versions, such implications may become illegal, see gap-system/gap#3006.
BTW, I would also recommend renaming
IsLinearCodeRep, replacing the misleadingRepsuffix.