Resolve issue 15

[cdwensley]

Adjusted the ReducePoly2 function so that, if the list of leading monomials has repeats then one poly is subtracted from another - repeated iteratively with resorting.
Do not expect that all the tests will pass, but waiting for other PRs to be approved before making further tests.

[cdwensley]

After merging other PRs, NMO example 3 was failing. That has been fixed by making sure new polynomials formed in ReducePol2 are made monic, but now test23 is failing. Am investigating further.

[codecov]

Codecov Report

Attention: Patch coverage is 82.77027% with 102 lines in your changes missing coverage. Please review.

Project coverage is 84.64%. Comparing base (c17cdc2) to head (a26373f).
Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   84.60%   84.64%   +0.03%     
==========================================
  Files          31       31              
  Lines        4144     4167      +23     
==========================================
+ Hits         3506     3527      +21     
- Misses        638      640       +2     

Files	Coverage Δ
lib/grobner.gi	84.57% <82.77%> (+0.41%)	⬆️

... and 4 files with indirect coverage changes

[cdwensley]

The problem with test23 was eventually fixed by moving the added loop, which checks for pairs of polynomials with the same lead term, from ReducePol2 to ReducePol. (In test23 the initial list of polynomials has length 64, but there are 21 duplicates (up to change of sign) so the added loop produces 21 zero polynomials, whose removal leaves a list of length 43.)

[cdwensley]

The problem with test23 was eventually fixed by moving the added loop, which checks for pairs of polynomials with the same lead term, from ReducePol2 to ReducePol. (In test23 the initial list of polynomials has length 64, but there are 21 duplicates (up to change of sign) so the added loop produces 21 zero polynomials, whose removal leaves a list of length 43.)

[fingolfin]

Thank you. And so sorry for forgetting about this.

I'd be happy to give you write access to this repository and then you could also become a maintainer for GBNP if you like. Just let me know if you are interested.

[cdwensley]

I would be happy to become a maintainer for GBNP and reduce your load just a little. Thank you for sorting this batch of PRs, since it is time I restarted work on IBNP. (For the last month I've only been working on XModAlg.)