Accommodate correctly pluralized ViewStrings in GAP

[wilfwilson]

In a future version of GAP, some nouns will be correctly pluralised to match their number, e.g. "generator" in <pc group of size 2 with 1 generator>. So I have made these changes to maximise compatibility.

See gap-system/gap#3992 and gap-system/gap#4050 for more context.

[codecov]

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   81.54%   81.54%           
=======================================
  Files          16       16           
  Lines        2476     2476           
=======================================
  Hits         2019     2019           
  Misses        457      457           

[olexandr-konovalov]

Thanks @wilfwilson! I wonder if we will gain more by asking for IdGroup rather then the order and number of generators...

[wilfwilson]

The purpose of this PR was to maintain the current level of information given by the tests, and I believe that the PR achieves that purpose.

As an example example, the previous output

[ <pc group of size 2 with 1 generators> ]

shows that the result is a list of one pc group of size 2 (with one generator), and my new test verifies

gap> Length(x) = 1 and IsPcGroup(x[1]) and Size(x[1]) = 2;

i.e. that the result is a list of one pc group of size 2.

Nevertheless I have added calls to CodePcGroup and IdGroup to enhance the tests.

[olexandr-konovalov]

@wilfwilson thanks! I am happy with this version too.

[fingolfin]

Thanks. I think this or a variant should be merged. Personally I'd streamline the changed tests a bit, as indicated in a comment

[wilfwilson]

Updated as suggested.

[olexandr-konovalov]

@heikodietrich I have merged this (forgot that this is a package, not main GAP repo). Hopefully you're happy with this PR!

[heikodietrich]

Thanks Alex, As far as I can tell, this is fine :-) Best wishes Heiko Sent by phone - please excuse brevity and typos -- Dr Heiko Dietrich Associate Professor Director of Postgraduate Studies School of Mathematics, Monash University users.monash.edu/~heikod

…

On Sun, 25 Oct 2020, 06:11 Alexander Konovalov, ***@***.***> wrote: @heikodietrich <https://github.com/heikodietrich> I have merged this (forgot that this is a package, not main GAP repo). Hopefully you're happy with this PR! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADNA76UTRA4ORE4SNB4SAUTSMMRFFANCNFSM4N3HHCHQ> .