Avoid declaring and using attribute 'Matrix' #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, introduce two attributes MatrixOfRack and MatrixOfCycleSet, and provide convenience methods for Matrix that delegate to the two. This way, Matrix is freed up to become an operation in GAP 4.12. Also optimize CycleSet2YB a bit.
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
- Coverage 99.52% 99.52% -0.01%
==========================================
Files 94 94
Lines 106313 106312 -1
==========================================
- Hits 105806 105805 -1
Misses 507 507
|
fingolfin
changed the title
There was a problem hiding this comment.
Looks good. @vendramin could such renaming break any user code? Also, would be good to add a test for IsNonDegenerate for the better test coverage of the diff.
|
@fingolfin please rebase to include Travis test in stable-4.11 too. |
|
@fingolfin checked myself - passes in stable-4.11. Thanks. |
|
Oops this missed a warning from the log file which did not fail the test: Will fix it now. |
olexandr-konovalov
pushed a commit
that referenced
this pull request
Nov 7, 2019
This was introduced in #64
|
Fixed in da8e135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, introduce two attributes MatrixOfRack and MatrixOfCycleSet,
and provide convenience methods for Matrix that delegate to the two.
This way, Matrix is freed up to become an operation in GAP 4.12.
Also optimize CycleSet2YB a bit.