Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FString string_view support, TextView member visibility #143

Merged
merged 2 commits into from
Aug 18, 2024

Conversation

russkel
Copy link
Contributor

@russkel russkel commented Aug 17, 2024

  • add string_view constructor support to FString
  • fix warning with unnecessary cast to size_t
  • change some methods to protected so a widget that extends the TextView can reason about the scroll height/width. (in my case: in order to make the TextView always scroll down if it is already scrolled to the bottom extent upon append)

@russkel russkel changed the title Feature/fix member visibility main FString string_view support, TextView member visibility Aug 17, 2024
@gansm
Copy link
Owner

gansm commented Aug 17, 2024

One of the patches uses the C++17 feature std::string_view. FINAL CUT was originally written in C++98 and ported from C++11 to C++14. So using std::string_view is not yet possible in the current codebase.

@russkel
Copy link
Contributor Author

russkel commented Aug 18, 2024

Would you find it acceptable to put kind of #ifdef check on the string_view features?

@russkel russkel force-pushed the feature/fix-member-visibility-main branch from 9706a52 to 665dbc2 Compare August 18, 2024 02:04
@russkel russkel force-pushed the feature/fix-member-visibility-main branch from 665dbc2 to 16b8de9 Compare August 18, 2024 02:06
@gansm gansm merged commit 2126115 into gansm:main Aug 18, 2024
15 checks passed
@gansm
Copy link
Owner

gansm commented Aug 18, 2024

I have also added a constructor for std::wstring_view. Furthermore, std::string_view and std::wstring_view are now also tested in the FString unit test.

0d691f1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants