allow users to modify attributes of the tracking cookie #305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
When using the Nexus Websockets tracking cookie option it might be necessary to modify the cookie attributes. This is helpful when using Nexus WAMP over Websockets from a Web browser. Web browsers vary on the handling of cookies received.
What is the current behavior?
RESOLVES #295
What is the new behavior?
This change exposes two new websocket server settings that can be modified by the user. These settings control which SameSite mode that the nexus-wamp-cookie will be sent back with. Further, it allows the user to set the Secure attribute of the cookie to restrict the cookie to secure connections.
What kind of change does this PR introduce?
Checklist:
(this is my first attempt at a PR of any kind. Please let me know what I might have missed)