Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schedule different kinds of jobs #23

Merged
merged 2 commits into from
Oct 20, 2020
Merged

schedule different kinds of jobs #23

merged 2 commits into from
Oct 20, 2020

Conversation

webbertakken
Copy link
Member

@webbertakken webbertakken commented Oct 20, 2020 •
edited
Loading

Changes

  • This dispatches different actions based on the editorVersions. We'll duplicate the whole workflow every time a version threshold from unity has different dependencies, so the matrix has to be changed.

Unfortunately we can not exit the workflow early yet and matrices are not flexible enough to do wildcards like attempted here as a quick hack.

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

GabLeRoux
GabLeRoux reviewed Oct 20, 2020
View reviewed changes
functions/src/logic/buildQueue/scheduler.ts Outdated
private static getEventTypeForEditorJob(editorVersionInfo: EditorVersionInfo) {
const { major, minor } = editorVersionInfo;

if (major >= 2019 && minor >= 3) {
Copy link
Member

@GabLeRoux GabLeRoux Oct 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@webbertakken webbertakken mentioned this pull request Oct 20, 2020
Merged
2 tasks
@webbertakken webbertakken merged commit 9c22ff9 into main Oct 20, 2020
@webbertakken webbertakken deleted the use-different-dispatch-events branch October 20, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabLeRoux GabLeRoux GabLeRoux left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webbertakken @GabLeRoux