-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade libstdc++ to support Autodesk FBX SDK for Unity #163
Conversation
We usually only add target-platform-specific additions to Could you please give an indication of how much space is used by the base image before and after? |
8fd329d
to
8a24114
Compare
Thanks. I was going to do base and then I wasn't sure. Reverted the change, and updated accordingly. As for size, it looks like it's 24mb.
I feel like more could be cleaned up, but I must be missing something. I added After using dive, it seems like most of the size is in the |
8a24114
to
c1e5599
Compare
@webbertakken - I was looking at the editor docker file, and noticed all
If we do that here,
The change is ~4MB. We could that for the first block as well and reduce the size of the image as well? |
474MB before, 396MB after. 78MB reduction |
It's a bit unclear to me how much the size is affected by each change, with both changes in the same MR.
If you could make a screenshot both before and after of the total size of the base image it will be easier to compare (per layer stats aren't very useful). Then we can rebase this PR and again see the difference of total image size before and after. |
Context Tried the changes locally to make a more exact comparison of
Proof Conclusion Upgrading the lib in this MR increases size by 4 megs, which is acceptable, as it allows (experimental) unity packages to work out of the box. |
…i#163) * deps: upgrades libstdc++ to support Autodesk FBX SDK for Unity * misc: move libstdc++ upgrade from editor to base * misc: remove /var/lib/apt/lists in base reducing image size
Changes
com.autodesk.fbx@4.1
requireslibstdc++ 6.0.28+
(see https://docs.unity3d.com/Packages/com.autodesk.fbx@4.1/manual/index.html)Unfortunately the version of
libstdc++
that comes with Ubuntu 18 is6.0.25
. Until the base images are updated to use Ubuntu 20 (which has a much newer version), we need to install an updatelibstdc++
.I was able to make a docker image:
This was tested at:
freezy/VisualPinball.Engine#387 (comment)
Checklist