This repository has been archived by the owner on Dec 7, 2020. It is now read-only.
HTTP Server and Upstream Timeouts #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to issue [263](#263). Permitting the users to set varioues timeouts on the http.Server and upstream proxy
|
sorry for the delay @jangaraj ... can you review please? |
|
LGTM 👍 . Note: default non zero values for server read/write timeouts can be breaking change, because default Golang zero values are used at the moment = no timeouts. Probably it'll be good to mention it in breaking changes section. Thanks! |
|
good point ... i'll put it into the changelog! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue 263. Permitting the users to set varioues timeouts on the http.Server and upstream proxy