Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first try at getting lensed CMB maps in #4

Merged
merged 28 commits into from
Jan 3, 2019
Merged

first try at getting lensed CMB maps in #4

merged 28 commits into from
Jan 3, 2019

Conversation

ajvanengelen
Copy link
Contributor

This is a tweak of a similar implementation in actsims https://github.com/ACTCollaboration/actsims/blob/96f4b98d9e580c33fb73f1334f476817b0286782/actsims/simTools.py#L24

This is just draft code and has not been tested! But we (Mat and Alex) are submitting it for a first review.

It is decoupled from the actsims repo but by default will load up the same lensed alm's.

mapsims/cmb.py Outdated Show resolved Hide resolved
Copy link
Member

@zonca zonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thanks for contributing this

Please let's try to make meaningful commit messages, also, try to consolidate commits before pushing with something like git rebase -i HEAD~10

mapsims/cmb.py Outdated Show resolved Hide resolved
mapsims/cmb.py Outdated Show resolved Hide resolved
mapsims/tests/test_cmb.py Show resolved Hide resolved
mapsims/cmb.py Outdated Show resolved Hide resolved
mapsims/cmb.py Outdated Show resolved Hide resolved
mapsims/cmb.py Outdated Show resolved Hide resolved
mapsims/cmb.py Outdated Show resolved Hide resolved
mapsims/cmb.py Outdated Show resolved Hide resolved
mapsims/tests/test_cmb.py Show resolved Hide resolved
@ajvanengelen
Copy link
Contributor Author

ajvanengelen commented Dec 6, 2018 via email

@msyriac
Copy link
Collaborator

msyriac commented Dec 21, 2018

I've made a first pass at integrating mapsims.cmb and so_pysm_models.alms. Could you have a look?

@msyriac
Copy link
Collaborator

msyriac commented Dec 21, 2018

Copy link
Member

@zonca zonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good, I tried to fix tests on Travis, let's see if it worked once the Travis tests complete

.travis.yml Show resolved Hide resolved
mapsims/cmb/__init__.py Outdated Show resolved Hide resolved
mapsims/tests/generate_cmb_case_data.py Outdated Show resolved Hide resolved
@zonca
Copy link
Member

zonca commented Jan 3, 2019

thanks @msyriac !

@zonca zonca merged commit d5da434 into master Jan 3, 2019
@zonca zonca deleted the cmbsim branch February 21, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants