Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include cstdint to fix compilation error on gcc 13 #229

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

toge
Copy link
Contributor

@toge toge commented Oct 16, 2023

I met compilation error on gcc 13. (work fine on gcc 12)

In file included from PDFWriter/DocumentContext.h:29,
                 from PDFWriter/PDFWriter.h:30,
                 from test_package.cpp:2:
/PDFWriter/TIFFImageHandler.h:142:9: error: ‘uint64_t’ does not name a type
  142 | typedef uint64_t tsize_t_compat;
      |         ^~~~~~~~
PDFWriter/TIFFImageHandler.h:83:1: note: ‘uint64_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
   82 | #include <list>
  +++ |+#include <cstdint>
   83 | #include <utility>

As compiler suggested, this patch include cstdint.
Please merge it if possible.

@galkahana galkahana merged commit 669e59f into galkahana:master Oct 17, 2023
1 check passed
@galkahana
Copy link
Owner

oh. Sorry for the trouble and thank you for your contribution. @toge. i merged for now, but do you mind checking if including '#include <stdint.h>' solves the problem instead? it'll support c99 and not just c11+, which is what i prefer.

@toge
Copy link
Contributor Author

toge commented Oct 17, 2023

@galkahana
Sorry, I forget that.
#include <stdint.h> is also fine to work. (I tested on gcc 13)

@galkahana
Copy link
Owner

Awsome thanks! So if you dont mind later today ill replace with stdint. following I will release a minor version.
Thanks again for letting me know and providing the correction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants