Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: harsher hex string parsing to avoid more dire parsing errors #195

Merged
merged 1 commit into from
Feb 18, 2023
Merged

fix: harsher hex string parsing to avoid more dire parsing errors #195

merged 1 commit into from
Feb 18, 2023

Commits on Feb 18, 2023

  1. fix: harsher hex string parsing to avoid more dire parsing errors 

    running fuzztests on my mac was failing erraticaly for one of the files.

also recreating a decompressed version didnt work.

traced the first problem to a too permissive hex string parsing which caused overreads.

and the second problem to a too restrictive zip decoding issue where end of stream error canceled the whole stream reading. which is a shame cause it could parse something worthwhile till then, like in this case.
    @galkahana
    galkahana committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    584bda2 View commit details
    Browse the repository at this point in the history