Fix masthead functionality for webhooks. #9810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
added
kind/bug
area/UI-UX
kind/refactoring
jmchilton
force-pushed
the
masthead_fixes_0
branch
from
2a95111
to
1184889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was exploring replacing the Backbone collection for a menu definition with a POJO for a new crack at #9030 when I noticed I had no clue how Webhooks could work with the changes in #9071 - turns out I don't think do. This should fix the problem though.
This also has some other cleanups for layout stuff - including deleting some scratchbook code that should have been deleted in #9071 and ES6-ification.