Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Apply exec options to connection #19651

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Feb 19, 2025

Fix bug introduced in #15496 (execution options were dropped)

Here we directly assign execution options to the connection object (unlike the previous version where they were passed as a dictionary). Note that unlike in SQLAlchemy 2.0, this method does NOT modify the connection in-place, which is why we use the returned value.

FOLLOW-UP: After this is merged, a follow-up PR should handle this:

  • For SQLAlchemy 2.0 (galaxy 24.1): we don't need the copy of the connection: the method modifies the connection in-place (ref)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs added kind/bug area/database Galaxy's database or data access layer labels Feb 19, 2025
@github-actions github-actions bot added this to the 24.1 milestone Feb 19, 2025
@jdavcs jdavcs merged commit 6c281d2 into galaxyproject:release_24.0 Feb 19, 2025
44 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/database Galaxy's database or data access layer kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants