Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Ctrl/Cmd-click on SwitchHistoryLink opens in new tab #18940

Conversation

ahmedhamidawan
Copy link
Member

Fixes #18897

Note: We can target dev instead if we want?

ctrl_click_switch_to_history_btn.mp4

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. There are multiple places to find the SwitchToHistoryLink component. For e.g.: Go to an invocation (open any invocation from the panel)
    2. On the top left, where it says the history name, click on it, and see that it changes your current history (if that history can be switched to)
    3. Try again, but this time Ctrl (if on Windows) or Cmd (if on Mac) + Click on the history name to see the history open in a new tab.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Copy link
Member

@itisAliRH itisAliRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, thanks @ahmedhamidawan!

It would be nice also to change the tooltip and explain this:
Click to switch or ctrl/cmd + click to open the history overview in a new tab

OR change the tooltip when ctrl/cmd is pressed.

@nsoranzo
Copy link
Member

nsoranzo commented Oct 5, 2024

It would be nice also to change the tooltip and explain this: Click to switch or ctrl/cmd + click to open the history overview in a new tab

OR change the tooltip when ctrl/cmd is pressed.

Not sure that's necessary, as that's the standard browser behaviour.

@mvdbeek mvdbeek merged commit 81d0578 into galaxyproject:release_24.1 Oct 8, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants