[24.1] Fix datatype validation of newly built collection #18738
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only request the summary view when polling the history for updates, so we don't serialize elements_datatypes, which is used to make sure that the dragged element is of the correct datatype.
This probably fixes https://sentry.galaxyproject.org/share/issue/790be09602694a638d66257004325163/:
where a user provided a collection of HTML elements into a fasta/fastq input. This is the only way I can think of where the validation would fail.
Has the nice side-effect that once you build a collection in the history the datatypes for the collection are shown (which currently requires reloading the history).
How to test the changes?
(Select all options that apply)
License