Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Optimize useInvocationGraph for Invocation view #18663

Conversation

ahmedhamidawan
Copy link
Member

@ahmedhamidawan ahmedhamidawan commented Aug 7, 2024

This ensures the graph is only loaded onto the editor once (initially). After that, we update the steps ref only when the step_jobs_summary changes. Only steps that have their jobs summary changed are updated as well.

Fixes #18660

Now, once the step_jobs_summary fetch every 3 seconds returns something different from last time, we look to update the individual steps (we do not load the editor again, we just update properties for the step such as .state or .jobs etc. for steps that had those values change). This seems to optimize it greatly and there is significantly lower lag or performance hit.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

This ensures the graph is only loaded onto the editor once (initially). After that, we update the `steps` ref for each step _only when_ the `step_jobs_summary` changes.

Fixes galaxyproject#18660
@ahmedhamidawan ahmedhamidawan marked this pull request as ready for review August 7, 2024 21:03
Copy link
Member

@ElectronicBlueberry ElectronicBlueberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement, thank you!
Test failure is unrelated (test fails in unrelated PRs as well)

@ElectronicBlueberry ElectronicBlueberry merged commit 2a670b4 into galaxyproject:release_24.1 Aug 8, 2024
28 of 29 checks passed
@ahmedhamidawan ahmedhamidawan deleted the optimize_useInvocationGraph branch August 8, 2024 13:34
@ahmedhamidawan

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants