Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tool test typing. #18590

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

jmchilton
Copy link
Member

It looks like we were passing two ... fairly distinct classes of dictionaries to ToolTestDescription's constructor. This is likely the problem was the models for these APIs I was trying to include in the tool state branch. I think the biggest typing improvement here is just to pull those out into different methods and paths through the code. There is a lot of typing fixes here and elimination of cast calls that was forcing the typing system to gloss over the differences.

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton added kind/refactoring cleanup or refactoring of existing code, no functional changes area/tool-framework area/backend labels Jul 23, 2024
@jmchilton jmchilton marked this pull request as ready for review July 23, 2024 15:10
@github-actions github-actions bot added this to the 24.2 milestone Jul 23, 2024
@mvdbeek mvdbeek merged commit 1c5ca4a into galaxyproject:dev Jul 29, 2024
47 of 55 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Jul 29, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend area/tool-framework kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants