Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like we were passing two ... fairly distinct classes of dictionaries to ToolTestDescription's constructor. This is likely the problem was the models for these APIs I was trying to include in the tool state branch. I think the biggest typing improvement here is just to pull those out into different methods and paths through the code. There is a lot of typing fixes here and elimination of
cast
calls that was forcing the typing system to gloss over the differences.How to test the changes?
(Select all options that apply)
License