Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some Toolshed 2.0 development paper-cuts #18538

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

davelopez
Copy link
Contributor

I found some things that drifted away since the last time this was working.

  • Added a server proxy entry to vite.config.ts to point to the development backend URL make run_test_backend.
    • For some reason, in my local setup, only GraphQL could connect to the real backend (localhost:9009), while the API calls tried to connect to localhost:4040 resulting in 404.
  • Fix an import issue in scripts/bootstrap_test_shed.py introduced inadvertently in a mass refactor.

Still, I can't get scripts/bootstrap_test_shed.py to run through in my local setup. There seem to be some missing test files and other development environment-dependent issues around it but it is not critical. It would be cool to have it though 😄

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    • Open a couple of terminals in galaxy/lib/tool_shed/webapp/frontend
    • Start the test server:
    • Start the frontend in dev mode:

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

$ make bootstrap_test_backend
cd ../../../..; . .venv/bin/activate; python scripts/bootstrap_test_shed.py
Traceback (most recent call last):
  File "/galaxy/scripts/bootstrap_test_shed.py", line 20, in <module>
    from galaxy.util import requests
ModuleNotFoundError: No module named 'galaxy'
make: *** [Makefile:22: bootstrap_test_backend] Error 1
@davelopez davelopez added kind/refactoring cleanup or refactoring of existing code, no functional changes area/toolshed labels Jul 12, 2024
@github-actions github-actions bot added this to the 24.2 milestone Jul 12, 2024
@davelopez
Copy link
Contributor Author

Thanks for the quick review John!

@davelopez davelopez merged commit 0cca58b into galaxyproject:dev Jul 15, 2024
50 of 53 checks passed
@davelopez davelopez deleted the update_toolshed2_dev_exp branch July 15, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/toolshed kind/refactoring cleanup or refactoring of existing code, no functional changes paper-cut
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants