Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow Card Buttons Refactors [GCC2024_COFEST] #18465

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

itisAliRH
Copy link
Member

@itisAliRH itisAliRH commented Jun 28, 2024

This PR refactors workflow card buttons and improves their UI.
Requires #18463

Workflow Actions Buttons On Hover and Focus (they were not in the same height)

Before After
image image
before after

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ElectronicBlueberry
Copy link
Member

Please add screenshots to the PR message which show the UI changes

@itisAliRH
Copy link
Member Author

Please add screenshots to the PR message which show the UI changes

@ElectronicBlueberry Screenshots added to the description ✌🏻

@guerler
Copy link
Contributor

guerler commented Jul 2, 2024

Failing tests seem to be related.

@dannon
Copy link
Member

dannon commented Jul 2, 2024

@guerler fixed in #18483

@dannon dannon merged commit 4dd34a8 into galaxyproject:dev Jul 2, 2024
30 of 32 checks passed
Copy link

github-actions bot commented Jul 2, 2024

This PR was merged without a "kind/" label, please correct.

@itisAliRH itisAliRH deleted the workflow-list-refactors branch July 2, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants