Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Fix null inputs in database operation tools #18385

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jun 12, 2024

And fix test that was supposed to cover this.
Fixes #18384

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

And fix test that was supposed to cover this.
Fixes galaxyproject#18384
@mvdbeek
Copy link
Member Author

mvdbeek commented Jun 12, 2024

Test failures are all unrelated, quay.io API is unreliable again.

@mvdbeek mvdbeek requested a review from a team June 12, 2024 13:57
Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jdavcs jdavcs merged commit 4fd73fc into galaxyproject:release_24.0 Jun 12, 2024
47 of 52 checks passed
@jdavcs jdavcs added this to the 24.1 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants