Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.2] Skip new history creation if user is anonymous and login is required #18319

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jun 4, 2024

Most straightforward fix for
#18317. I have not been able to reproduce the issue itself though, only a single history is being created in my testing.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Most straightforward fix for
galaxyproject#18317. I have not been
able to reproduce the issue itself though, only a single history is
being created in my testing.
@github-actions github-actions bot added this to the 23.2 milestone Jun 4, 2024
@mvdbeek mvdbeek changed the title [23.2] Skip new history creation of user is anonymous and login is required [23.2] Skip new history creation if user is anonymous and login is required Jun 4, 2024
@bernt-matthias
Copy link
Contributor

Excellent. I will try to test this tomorrow.

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that this does the trick. Thanks a lot.

@mvdbeek mvdbeek merged commit bd4a529 into galaxyproject:release_23.2 Jun 6, 2024
37 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants