[24.0] Don't set dataset peek for errored jobs #18231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with the extended metadata logic, and prevents:
which only makes it harder to diagnose the actual error, which in the
case of https://sentry.galaxyproject.org/share/issue/831261683ce642a4976efa20a9a0e55c/
is
\nslurmstepd: error: *** JOB 1910486 ON js2-gpu-small0 CANCELLED AT 2024-05-26T23:30:00 DUE TO TIME LIMIT ***\n
Also merges line_count handling to common method, never fail further processing of the job if
set_peek
fails and fix gro set_peek method to produce a blurb indicating that the file is likely not a valid GRO file.How to test the changes?
(Select all options that apply)
License