Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Don't fail metadata if we only have an extra output files dir #18179

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented May 20, 2024

This used to be fine in some deployments, and not in others. I think this is fine, considering we got the extra output files dir the job completed successfully. We expect this for composite datasets with auto_primary_file, but other cases like directory datatypes could also be doing this.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek force-pushed the fix_extra_files_dir_only_collection_pulsar branch from 2012b85 to fa5e852 Compare May 21, 2024 07:06
@mvdbeek mvdbeek marked this pull request as ready for review May 21, 2024 12:19
@github-actions github-actions bot added this to the 24.1 milestone May 21, 2024
@mvdbeek mvdbeek force-pushed the fix_extra_files_dir_only_collection_pulsar branch from b190559 to e80204e Compare May 21, 2024 12:25
@mvdbeek mvdbeek requested a review from jmchilton May 21, 2024 14:27
@jdavcs jdavcs removed this from the 24.1 milestone May 23, 2024
@mvdbeek mvdbeek requested a review from a team May 23, 2024 12:40
@mvdbeek
Copy link
Member Author

mvdbeek commented May 23, 2024

I've deployed this to main already and it fixes galaxyproject/usegalaxy-tools#731

@jmchilton jmchilton merged commit 37aeadd into galaxyproject:release_24.0 May 23, 2024
51 checks passed
@jdavcs jdavcs added this to the 24.1 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants