Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Fix activity bar touch events on iOS devices #18109

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented May 8, 2024

I'm not sure what the issue is here, the minimal fix is this:

diff --git a/client/src/components/Popper/usePopper.ts b/client/src/components/Popper/usePopper.ts
index ad18847d8d..183d2e49be 100644
--- a/client/src/components/Popper/usePopper.ts
+++ b/client/src/components/Popper/usePopper.ts
@@ -190,7 +190,7 @@ export function usePopperjs(
                 on(referenceRef.value!, "mouseout", doMouseout);
                 on(popperRef.value!, "mouseout", doMouseout);
                 on(referenceRef.value!, "mousedown", doMouseout);
-                on(popperRef.value!, "mousedown", doMouseout);
+                // on(popperRef.value!, "mousedown", doMouseout);
                 break;
             }

but I think we can probably just rely on events happening on referenceRef.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.1 milestone May 8, 2024
@mvdbeek mvdbeek requested a review from guerler May 9, 2024 09:41
@mvdbeek
Copy link
Member Author

mvdbeek commented May 9, 2024

This also happens on an Ipad, and the fix works there as well.

I'm not sure what the issue is here, the minimal fix is this:
```
diff --git a/client/src/components/Popper/usePopper.ts b/client/src/components/Popper/usePopper.ts
index ad18847d8d..183d2e49be 100644
--- a/client/src/components/Popper/usePopper.ts
+++ b/client/src/components/Popper/usePopper.ts
@@ -190,7 +190,7 @@ export function usePopperjs(
                 on(referenceRef.value!, "mouseout", doMouseout);
                 on(popperRef.value!, "mouseout", doMouseout);
                 on(referenceRef.value!, "mousedown", doMouseout);
-                on(popperRef.value!, "mousedown", doMouseout);
+                // on(popperRef.value!, "mousedown", doMouseout);
                 break;
             }

```
but I think we can probably just rely on events happening on
referenceRef.
@mvdbeek mvdbeek force-pushed the fix_activity_bar_touch_iphone branch from 24e71cc to c994951 Compare May 9, 2024 10:12
@mvdbeek mvdbeek changed the base branch from dev to release_24.0 May 9, 2024 10:13
@mvdbeek mvdbeek changed the title Fix activity bar touch events on iphone [24.0] Fix activity bar touch events on iOS devices May 9, 2024
@davelopez davelopez merged commit 43d79fd into galaxyproject:release_24.0 May 13, 2024
32 checks passed
@martenson martenson deleted the fix_activity_bar_touch_iphone branch May 13, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants