Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.0] Fix vanishing connections on workflow upgrade #18107

Merged
merged 2 commits into from
May 13, 2024
Merged

[24.0] Fix vanishing connections on workflow upgrade #18107

merged 2 commits into from
May 13, 2024

Conversation

ElectronicBlueberry
Copy link
Member

fixes #17986

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.1 milestone May 8, 2024
mvdbeek
mvdbeek approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any clue why this only happens for the refactoring response ?

@ElectronicBlueberry
Copy link
Member Author

Any clue why this only happens for the refactoring response ?

The other method (_loadCurrent) has the store reset before the data fetching, which adds a delay in between the reset and fromSimple calls. Would the API response be instant, they would also disappear there.

@mvdbeek
Copy link
Member

mvdbeek commented May 8, 2024

Should we move the nextTick call into the resetStores function then ?

@mvdbeek
Copy link
Member

mvdbeek commented May 9, 2024

And can you target 24.0 ?

@ElectronicBlueberry ElectronicBlueberry force-pushed the fix-upgrade-removes-connections branch from 455f637 to 4129a9b Compare May 13, 2024 13:17
@ElectronicBlueberry ElectronicBlueberry changed the base branch from dev to release_24.0 May 13, 2024 13:18
@ElectronicBlueberry ElectronicBlueberry changed the title Fix Vanishing Connections on Workflow Upgrade [24.0] Fix Vanishing Connections on Workflow Upgrade May 13, 2024
@ElectronicBlueberry ElectronicBlueberry merged commit 1552e06 into galaxyproject:release_24.0 May 13, 2024
28 checks passed
@jdavcs jdavcs changed the title [24.0] Fix Vanishing Connections on Workflow Upgrade [24.0] Fix vanishing connections on workflow upgrade May 23, 2024
@ElectronicBlueberry ElectronicBlueberry mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
area/UI-UX kind/bug
Projects
None yet
Milestone
24.1
Development

Successfully merging this pull request may close these issues.

Connections vanish when upgrading a subworkflow
2 participants
@ElectronicBlueberry @mvdbeek