-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[23.2] Updated the datatypes name for FASTK tool #18053
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, we can't change them as that breaks existing tools and datasets, but you can add additional lines.
Can we grep in the TS if they have been used? They have been added for FASTK but FASTK was never merged and does not exist yet. We can also use the old names, we just thought to make the names less generic. |
No, we have no such record (and the toolshed count of clones are just fantasy numbers). I am confused though, aren't we using fastk in VGP ? If there's really very little chance we ever produced these datatypes then the change is ok. |
No, currently FASTK is not been used in VGP yet. The plan ahead is to replace the currently used tool (meryl) with FASTK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok from my side, given that fastk was never released.
ping @mvdbeek |
One approval form @bgruening is enough as long as there is no request for changes, I didn't realise this is waiting for me. |
Updated the datatype names of FASTK tool. This was done to make the datatypes more specific for FASTK use case.
These datatypes were not used until now, as the FASTK wrapper was not yet merged on tools-iuc.
Relevant to:
galaxyproject/tools-iuc#5965
#17265
How to test the changes?
(Select all options that apply)
License