Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] History import - show user feedback on completion. #17980

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

dannon
Copy link
Member

@dannon dannon commented Apr 12, 2024

Fixes #17933

Just adds a simple info message on history import modal completion (but not cancel) saying that the history has been copied and set to the user's active history:

image

Also swaps the button back to the standard non-primary-action variant to match more of the 'tertiary action' buttons across the application.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon dannon marked this pull request as ready for review April 12, 2024 20:12
@github-actions github-actions bot added this to the 24.1 milestone Apr 12, 2024
@dannon dannon changed the title [25.0] History import feedback [25.0] History import - show user feedback on completion. Apr 12, 2024
@dannon dannon changed the title [25.0] History import - show user feedback on completion. [24.0] History import - show user feedback on completion. Apr 12, 2024
@martenson martenson merged commit 3a35c82 into galaxyproject:release_24.0 Apr 12, 2024
31 checks passed
@galaxyproject galaxyproject deleted a comment from github-actions bot Apr 12, 2024
@hexylena
Copy link
Member

thanks @dannon this is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants